Allow emails table to contain multiple emails per user
#11642
Conversation
kailan
force-pushed
the
multiple-emails-schema
branch
3 times, most recently
from
f6ebfe0 to
77ebf49
Compare
kailan
force-pushed
the
multiple-emails-schema
branch
from
77ebf49 to
edf516e
Compare
| -- Set `is_primary` to true for existing emails | ||
| UPDATE emails SET is_primary = true; |
There was a problem hiding this comment.
we currently have 72k rows in the emails table. I'm a bit scared about running this as part of the migration, since the running migration will block the API server from restarting.
@eth3lbert any thoughts on this?
I guess we could extract the add column is_primary above to a dedicated migration/PR, deploy that to run the migration, then manually run the update is_primary = true without blocking the API server, and then merge/deploy the rest of this migration 🤔
There was a problem hiding this comment.
I guess we could extract the
add column is_primaryabove to a dedicated migration/PR, deploy that to run the migration, then manually run theupdate is_primary = truewithout blocking the API server, and then merge/deploy the rest of this migration 🤔
Yeah, I second this! I think this would be the most proper way to minimize potential issues caused by the introduced database migration.
There was a problem hiding this comment.
I split this into a separate migration and will open a separate PR including just that.
Turbo87
added
C-enhancement ✨
|
Haven't forgotten about this! Thanks for your review – aiming to address your comments soon. |
3 participants
This PR is split from #11629 – it contains just the database schema-related changes, with no changes to the API, frontend, or any user-visible behaviour, barring a change to the description of three properties of the
/api/v1/meresponse in the OpenAPI schema.I previously had a note here about it being possible for an email address to exist on more than one user account, but this is the current behaviour in production so I have removed it.
Relates to #11597.